Remove Real::isNearZero

fintarin · Jul 31, 2023 · 6c54a30 · 6c54a30
1 parent 7a66a65
commit 6c54a30
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 45 deletions.
diff --git a/include/fintamath/numbers/Real.hpp b/include/fintamath/numbers/Real.hpp
@@ -46,8 +46,6 @@ class Real : public INumberCRTP<Real> {
 
   int sign() const;
 
-  bool isNearZero() const;
-
   const boost::multiprecision::cpp_dec_float_100 &getBackend() const;
 
   static MathObjectTypeId getTypeIdStatic() {
@@ -75,8 +73,6 @@ class Real : public INumberCRTP<Real> {
   boost::multiprecision::cpp_dec_float_100 backend;
 
   uint8_t ouputPrecision = FINTAMATH_PRECISION;
-
-  static const boost::multiprecision::cpp_dec_float_100 DELTA;
 };
 
 }
diff --git a/src/fintamath/numbers/Real.cpp b/src/fintamath/numbers/Real.cpp
@@ -12,13 +12,6 @@ using namespace boost::multiprecision;
 
 namespace fintamath {
 
-static cpp_dec_float_100 initDelta() {
-  static const cpp_dec_float_100 delta = pow(cpp_dec_float_100(10), -FINTAMATH_PRECISION);
-  return delta;
-}
-
-const cpp_dec_float_100 Real::DELTA = initDelta();
-
 Real::Real() = default;
 
 Real::Real(const Real &rhs) = default;
@@ -125,16 +118,12 @@ int Real::sign() const {
   return backend.sign();
 }
 
-bool Real::isNearZero() const {
-  return abs(backend) < DELTA;
-}
-
 const cpp_dec_float_100 &Real::getBackend() const {
   return backend;
 }
 
 bool Real::equals(const Real &rhs) const {
-  return (*this - rhs).isNearZero();
+  return backend == rhs.backend;
 }
 
 bool Real::less(const Real &rhs) const {
@@ -167,10 +156,6 @@ Real &Real::multiply(const Real &rhs) {
 }
 
 Real &Real::divide(const Real &rhs) {
-  if (rhs.isNearZero()) {
-    throw UndefinedBinaryOperatorException("/", toString(), rhs.toString());
-  }
-
   backend /= rhs.backend;
   return *this;
 }

diff --git a/src/fintamath/numbers/RealFunctions.cpp b/src/fintamath/numbers/RealFunctions.cpp
@@ -11,21 +11,10 @@ Real abs(const Real &rhs) {
 }
 
 Real sqrt(const Real &rhs) {
-  if (rhs < 0) {
-    throw UndefinedFunctionException("sqrt", {rhs.toString()});
-  }
-
   return {sqrt(rhs.getBackend())};
 }
 
 Real pow(const Real &lhs, const Real &rhs) {
-  if (lhs.isNearZero() && rhs.isNearZero()) {
-    throw UndefinedBinaryOperatorException("^", lhs.toString(), rhs.toString());
-  }
-  if (lhs < 0 && !is<Integer>(rhs.toMinimalObject())) { // TODO: do not use toMinimalObject
-    throw UndefinedBinaryOperatorException("^", lhs.toString(), rhs.toString());
-  }
-
   cpp_dec_float_100 res(pow(lhs.getBackend(), rhs.getBackend()));
 
   if (res.backend().isinf() || res.backend().isnan()) {
@@ -73,23 +62,11 @@ Real lg(const Real &rhs) {
 }
 
 Real sin(const Real &rhs) {
-  Real res(sin(rhs.getBackend()));
-
-  if (res.isNearZero()) {
-    return 0;
-  }
-
-  return res;
+  return {sin(rhs.getBackend())};
 }
 
 Real cos(const Real &rhs) {
-  Real res(cos(rhs.getBackend()));
-
-  if (res.isNearZero()) {
-    return 0;
-  }
-
-  return res;
+  return {cos(rhs.getBackend())};
 }
 
 Real tan(const Real &rhs) {