Skip to content

Commit

Permalink
Renaming
Browse files Browse the repository at this point in the history
  • Loading branch information
fintarin committed Apr 4, 2024
1 parent 517ed38 commit 75deec2
Show file tree
Hide file tree
Showing 13 changed files with 31 additions and 31 deletions.
4 changes: 2 additions & 2 deletions include/fintamath/expressions/IExpression.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class IExpression : public IMathObject {

virtual ArgumentPtr postSimplify() const;

virtual ArgumentPtr approximateSimplify() const;
virtual ArgumentPtr approximate() const;

virtual ArgumentPtr setPrecision(unsigned precision, const Integer &maxInt) const;

Expand All @@ -52,7 +52,7 @@ class IExpression : public IMathObject {

static void postSimplifyChild(ArgumentPtr &child);

static void approximateSimplifyChild(ArgumentPtr &child);
static void approximateChild(ArgumentPtr &child);

static void setPrecisionChild(ArgumentPtr &child, unsigned precision, const Integer &maxInt);

Expand Down
2 changes: 1 addition & 1 deletion src/fintamath/expressions/Expression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ Expression approximate(const Expression &rhs, const unsigned precision) {
});

Expression approxExpr = rhs;
Expression::approximateSimplifyChild(approxExpr.child);
Expression::approximateChild(approxExpr.child);
Expression::setPrecisionChild(approxExpr.child, precision, cache[precision]);
approxExpr.updateStringMutable();

Expand Down
10 changes: 5 additions & 5 deletions src/fintamath/expressions/IExpression.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,12 @@ void IExpression::postSimplifyChild(ArgumentPtr &child) {
}
}

void IExpression::approximateSimplifyChild(ArgumentPtr &child) {
void IExpression::approximateChild(ArgumentPtr &child) {
if (const auto constChild = cast<IConstant>(child)) {
child = (*constChild)();
}
else if (const auto exprChild = cast<IExpression>(child)) {
child = exprChild->approximateSimplify();
child = exprChild->approximate();
}
}

Expand Down Expand Up @@ -292,11 +292,11 @@ ArgumentPtr IExpression::postSimplify() const {
return {};
}

ArgumentPtr IExpression::approximateSimplify() const {
ArgumentPtr IExpression::approximate() const {
ArgumentPtr simpl = simplify();

if (!is<IExpression>(simpl)) {
approximateSimplifyChild(simpl);
approximateChild(simpl);
return simpl;
}

Expand All @@ -307,7 +307,7 @@ ArgumentPtr IExpression::approximateSimplify() const {
size_t numberChildrenCount = 0;

for (auto &child : approxChildren) {
approximateSimplifyChild(child);
approximateChild(child);

if (const auto childNum = cast<INumber>(child)) {
numberChildrenCount++;
Expand Down
4 changes: 2 additions & 2 deletions src/fintamath/expressions/binary/CompExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ ArgumentPtr CompExpr::rateSimplify(const IFunction &func, const ArgumentPtr &lhs
ArgumentPtr newLhs = makePolynom(Add{}, std::move(children));
simplifyChild(newLhs);

approximateSimplifyChild(rate);
approximateChild(rate);
if (isNegativeNumber(rate)) {
return makeExpr(*cast<IFunction>(getOppositeFunction(func)), newLhs, rhs);
}
Expand All @@ -243,7 +243,7 @@ ArgumentPtr CompExpr::approxSimplify(const IFunction &func, const ArgumentPtr &l
}

ArgumentPtr approxLhs = lhs;
approximateSimplifyChild(approxLhs);
approximateChild(approxLhs);
if (!is<INumber>(approxLhs)) {
return {};
}
Expand Down
8 changes: 4 additions & 4 deletions src/fintamath/expressions/binary/LogExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -46,21 +46,21 @@ const std::shared_ptr<IFunction> &LogExpr::getOutputFunction() const {
return IBinaryExpression::getFunction();
}

ArgumentPtr LogExpr::approximateSimplify() const {
ArgumentPtr LogExpr::approximate() const {
if (*lhsChild == E{}) {
const auto approxExpr = cast<LogExpr>(clone());
approximateSimplifyChild(approxExpr->rhsChild);
approximateChild(approxExpr->rhsChild);

if (is<INumber>(approxExpr->rhsChild)) {
if (const auto res = cast<INumber>(approxExpr->IBinaryExpression::approximateSimplify())) {
if (const auto res = cast<INumber>(approxExpr->IBinaryExpression::approximate())) {
return res;
}
}

return approxExpr->simplify();
}

return IBinaryExpression::approximateSimplify();
return IBinaryExpression::approximate();
}

ArgumentPtr LogExpr::setPrecision(const unsigned precision, const Integer &maxInt) const {
Expand Down
2 changes: 1 addition & 1 deletion src/fintamath/expressions/binary/LogExpr.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class LogExpr final : public IBinaryExpressionCRTP<LogExpr> {
const std::shared_ptr<IFunction> &getOutputFunction() const override;

protected:
ArgumentPtr approximateSimplify() const override;
ArgumentPtr approximate() const override;

ArgumentPtr setPrecision(unsigned precision, const Integer &maxInt) const override;

Expand Down
12 changes: 6 additions & 6 deletions src/fintamath/expressions/binary/PowExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,19 +96,19 @@ const std::shared_ptr<IFunction> &PowExpr::getOutputFunction() const {
return IBinaryExpression::getFunction();
}

ArgumentPtr PowExpr::approximateSimplify() const {
ArgumentPtr PowExpr::approximate() const {
if (const auto ratRhsChild = cast<Rational>(rhsChild); ratRhsChild && ratRhsChild->denominator() <= maxPreciseRoot) {
auto approxExpr = cast<PowExpr>(clone());
approximateSimplifyChild(approxExpr->lhsChild);
approximateChild(approxExpr->lhsChild);

if (is<INumber>(approxExpr->lhsChild)) {
return approxExpr->IBinaryExpression::approximateSimplify();
return approxExpr->IBinaryExpression::approximate();
}

return approxExpr;
}

return IBinaryExpression::approximateSimplify();
return IBinaryExpression::approximate();
}

ArgumentPtr PowExpr::setPrecision(const unsigned precision, const Integer &maxInt) const {
Expand Down Expand Up @@ -251,7 +251,7 @@ ArgumentPtr PowExpr::constSimplify(const IFunction & /*func*/, const ArgumentPtr

if (!containsVariable(lhs)) {
ArgumentPtr approxLhs = lhs;
approximateSimplifyChild(approxLhs);
approximateChild(approxLhs);

if (const auto lhsNum = cast<INumber>(approxLhs)) {
if (lhsNum->isComplex()) {
Expand Down Expand Up @@ -300,7 +300,7 @@ ArgumentPtr PowExpr::constSimplify(const IFunction & /*func*/, const ArgumentPtr
if (is<Inf>(lhs) || is<ComplexInf>(lhs)) {
if (!containsVariable(rhs)) {
ArgumentPtr approxRhs = rhs;
approximateSimplifyChild(approxRhs);
approximateChild(approxRhs);

if (const auto rhsComplex = cast<Complex>(approxRhs)) {
if (rhsComplex->real() == Integer(0)) {
Expand Down
2 changes: 1 addition & 1 deletion src/fintamath/expressions/binary/PowExpr.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class PowExpr final : public IBinaryExpressionCRTP<PowExpr> {
const std::shared_ptr<IFunction> &getOutputFunction() const override;

protected:
ArgumentPtr approximateSimplify() const override;
ArgumentPtr approximate() const override;

ArgumentPtr setPrecision(unsigned precision, const Integer &maxInt) const override;

Expand Down
6 changes: 3 additions & 3 deletions src/fintamath/expressions/unary/FloorCeilExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,18 @@ FloorCeilExpr::FloorCeilExpr(const IFunction &inFunc, ArgumentPtr inChild)
FloorCeilExpr::SimplifyFunctionVector FloorCeilExpr::getFunctionsForPostSimplify() const {
static const SimplifyFunctionVector simplifyFunctions = {
&FloorCeilExpr::negSimplify,
&FloorCeilExpr::intApproximateSimplify,
&FloorCeilExpr::intapproximate,
};
return simplifyFunctions;
}

ArgumentPtr FloorCeilExpr::intApproximateSimplify(const IFunction &func, const ArgumentPtr &rhs) {
ArgumentPtr FloorCeilExpr::intapproximate(const IFunction &func, const ArgumentPtr &rhs) {
if (containsVariable(rhs)) {
return {};
}

ArgumentPtr approx = rhs->clone();
approximateSimplifyChild(approx);
approximateChild(approx);

if (auto res = cast<INumber>(callFunction(func, {approx}))) {
return res;
Expand Down
2 changes: 1 addition & 1 deletion src/fintamath/expressions/unary/FloorCeilExpr.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class FloorCeilExpr final : public IUnaryExpressionCRTP<FloorCeilExpr> {
SimplifyFunctionVector getFunctionsForPostSimplify() const override;

private:
static ArgumentPtr intApproximateSimplify(const IFunction &func, const ArgumentPtr &rhs);
static ArgumentPtr intapproximate(const IFunction &func, const ArgumentPtr &rhs);

static ArgumentPtr negSimplify(const IFunction &func, const ArgumentPtr &rhs);

Expand Down
6 changes: 3 additions & 3 deletions src/fintamath/expressions/unary/SignExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ SignExpr::SimplifyFunctionVector SignExpr::getFunctionsForPostSimplify() const {
static const SimplifyFunctionVector simplifyFunctions = {
&SignExpr::constSimplify,
&SignExpr::negSimplify,
&SignExpr::intApproximateSimplify,
&SignExpr::intapproximate,
};
return simplifyFunctions;
}
Expand All @@ -47,13 +47,13 @@ ArgumentPtr SignExpr::constSimplify(const IFunction & /*func*/, const ArgumentPt
return {};
}

ArgumentPtr SignExpr::intApproximateSimplify(const IFunction &func, const ArgumentPtr &rhs) {
ArgumentPtr SignExpr::intapproximate(const IFunction &func, const ArgumentPtr &rhs) {
if (containsVariable(rhs)) {
return {};
}

ArgumentPtr approx = rhs->clone();
approximateSimplifyChild(approx);
approximateChild(approx);

if (const auto approxNum = cast<INumber>(approx); approxNum && !approxNum->isComplex()) {
return callFunction(func, {approx});
Expand Down
2 changes: 1 addition & 1 deletion src/fintamath/expressions/unary/SignExpr.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SignExpr final : public IUnaryExpressionCRTP<SignExpr> {
private:
static ArgumentPtr constSimplify(const IFunction &func, const ArgumentPtr &rhs);

static ArgumentPtr intApproximateSimplify(const IFunction &func, const ArgumentPtr &rhs);
static ArgumentPtr intapproximate(const IFunction &func, const ArgumentPtr &rhs);

static ArgumentPtr negSimplify(const IFunction &func, const ArgumentPtr &rhs);
};
Expand Down
2 changes: 1 addition & 1 deletion tests/src/expressions/IExpressionTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class TestExpression final : public IExpressionCRTP<TestExpression> {
return clone();
}

ArgumentPtr approximateSimplify() const override {
ArgumentPtr approximate() const override {
return clone();
}
};
Expand Down

0 comments on commit 75deec2

Please sign in to comment.