Move rhs == 0 check from LogExpression to Ln

fintarin · Aug 2, 2023 · e4cd9b6 · e4cd9b6
1 parent cbbac73
commit e4cd9b6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/fintamath/expressions/binary/LogExpression.cpp b/src/fintamath/expressions/binary/LogExpression.cpp
@@ -76,10 +76,6 @@ ArgumentPtr LogExpression::constSimplify(const IFunction & /*func*/, const Argum
   }
 
   if (*lhs == E()) {
-    if (*rhs == Integer(0)) {
-      return NegInf().clone();
-    }
-
     return callFunction(Ln(), {rhs});
   }
 

diff --git a/src/fintamath/functions/logarithms/Ln.cpp b/src/fintamath/functions/logarithms/Ln.cpp
@@ -1,11 +1,18 @@
 #include "fintamath/functions/logarithms/Ln.hpp"
 
+#include "fintamath/literals/constants/NegInf.hpp"
 #include "fintamath/numbers/RealFunctions.hpp"
 
 namespace fintamath {
 
 std::unique_ptr<IMathObject> Ln::call(const ArgumentsRefVector &argsVect) const {
-  return ln(convert<Real>(argsVect.front().get())).toMinimalObject();
+  const auto &rhs = cast<INumber>(argsVect.front().get());
+
+  if (rhs == Integer(0)) {
+    return NegInf().clone();
+  }
+
+  return ln(convert<Real>(rhs)).toMinimalObject();
 }
 
 }