Small refactoring

fintarin · Oct 27, 2023 · f18058b · f18058b
1 parent a33b5d4
commit f18058b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/include/fintamath/core/MultiMethod.hpp b/include/fintamath/core/MultiMethod.hpp
@@ -39,7 +39,7 @@ class MultiMethod<Res(ArgsBase...)> {
   }
 
   bool contains(const auto &...args) const {
-    return callbacks.find(CallbackId(args.getType()...)) != callbacks.end();
+    return callbacks.contains(CallbackId(args.getType()...));
   }
 
 private:

diff --git a/src/fintamath/expressions/IExpression.cpp b/src/fintamath/expressions/IExpression.cpp
@@ -310,10 +310,11 @@ ArgumentPtr IExpression::approximateSimplify() const {
 
   bool containsVar = containsVariable(simplExpr);
 
-  if (containsVar) {
-    if (numberChildrenCount < 2 || IFunction::Type(approxChildren.size()) == getFunction()->getFunctionType()) {
-      return approxExpr;
-    }
+  if (containsVar &&
+      (numberChildrenCount < 2 ||
+       IFunction::Type(approxChildren.size()) == getFunction()->getFunctionType())) {
+
+    return approxExpr;
   }
 
   ArgumentPtr approxSimpl = approxExpr->simplify();

diff --git a/src/fintamath/functions/powers/Root.cpp b/src/fintamath/functions/powers/Root.cpp
@@ -152,8 +152,8 @@ std::unique_ptr<IMathObject> Root::rootSimplify(const Rational &lhs, const Integ
 
   if (ArgumentPtr numeratorRes = perfectRoot(lhs.numerator(), rhs)) {
     if (ArgumentPtr denominatorRes = perfectRoot(lhs.denominator(), rhs)) {
-      auto numer = cast<Integer>(*numeratorRes);
-      auto denom = cast<Integer>(*denominatorRes);
+      const auto &numer = cast<Integer>(*numeratorRes);
+      const auto &denom = cast<Integer>(*denominatorRes);
       return Rational(numer, denom).toMinimalObject();
     }