Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiplefactorConfig.state support in Project and Tenant config #569

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ynaka81
Copy link

@ynaka81 ynaka81 commented Jul 17, 2023

  • Add MultiplefactorConfig.state support in Project and Tenant config which has been implemented in firebase-admin-node.
  • When I asked Firebase support, I was sure that you were planning to support this feature in the future. That's why I directly created a PR but if you think it's better to create a new issue first, I will follow the convention in this repository.

@pragatimodi
Copy link
Contributor

Hi @ynaka81

Thanks for contributing to Firebase SDKs.
May I know the reason for raising this PR? Is it blocking any functionality on your end?
We did not add it to Golang SDKs because MultiFactorConfig.State is only for enabling providers listed in EnabledProviders. It should not affect any providers in the ProviderConfigs list as they have an independent State field.

@ynaka81
Copy link
Author

ynaka81 commented Jul 25, 2023

Thank you for your response @pragatimodi

Yes, I want to enable/disable "Multi-Factor Authentication" (the following image) with the back-end service written in Go. Actually, I tried to enable/disable this setting by State field in the ProviderConfigs list but I could not.

Screenshot from 2023-07-25 11-17-56

In Node SDK, it looks like it is supported by multiFactorConfig: { state: 'ENABLED' } according to this document https://cloud.google.com/identity-platform/docs/multi-tenancy-managing-tenants#creating_a_tenant. That's why I thought it would be good to add the same interface to the Go SDK. I also asked your support team whether there is any way to enable/disable this setting and I was confident that you are planning to support all SDKs from their response.

Unfortunately, currently managing the Multi-factor authentication can only be achieved by using Node.js Admin SDK. You can find a full table of supported features by each SDK in the documentation here. As you can see, no SDK other than Node can currently manage multi-factor features. Recently, there have been several changes and updates to many features of Firebase Authentication and I think that our engineers wanted to have at least one SDK that supports all of them for now.
I realize that this is not the answer you were hoping for. However, as an action for your case, I’ll escalate your suggestion to our engineers. I believe that the MFA support will be added to all of the SDKs in the future, but hopefully a Feature Request from one of our users will expedite this process. :)

If there is a workaround to enable/disable this setting in the current SDK or if I missed something, please let me know. I will follow those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants