Skip to content

Commit

Permalink
Removing parameter groups
Browse files Browse the repository at this point in the history
  • Loading branch information
Pijush Chakraborty committed Nov 12, 2024
1 parent 20749d7 commit 681d353
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 17 deletions.
12 changes: 0 additions & 12 deletions firebase_admin/remote_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,6 @@ def __init__(self, etag, template_data):
if 'version' in template_data:
self._version = template_data['version']

if 'parameterGroups' in template_data:
if template_data['parameterGroups'] is not None:
self._parameter_groups = template_data['parameterGroups']
else:
raise ValueError('Remote Config parameterGroups must be a non-null object')
else:
self.parameter_groups = {}

self._etag = ''
if etag is not None and isinstance(etag, str):
self._etag = etag
Expand All @@ -84,10 +76,6 @@ def version(self):
def conditions(self):
return self._conditions

@property
def parameter_groups(self):
return self._parameter_groups


class ServerTemplate:
"""Represents a Server Template with implementations for loading and evaluting the tempalte."""
Expand Down
6 changes: 1 addition & 5 deletions tests/test_remote_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ def test_rc_instance_get_server_template(self):
'test_key': 'test_value'
},
'conditions': [],
'parameterGroups': {},
'version': 'test'
})

Expand All @@ -75,7 +74,6 @@ def test_rc_instance_get_server_template_empty_params(self):
recorder = []
response = json.dumps({
'conditions': [],
'parameterGroups': {},
'version': 'test'
})

Expand Down Expand Up @@ -109,13 +107,12 @@ def test_init_server_template(self):
'parameters': {
'test_key': 'test_value'
},
'parameterGroups': '',
'version': '',
}

template = remote_config.init_server_template(
app=app,
template_data=ServerTemplateData('etag', template_data) # Use ServerTemplateData here
template_data=ServerTemplateData('etag', template_data)
)

config = template.evaluate()
Expand All @@ -133,7 +130,6 @@ async def test_get_server_template(self):
'test_key': 'test_value'
},
'conditions': [],
'parameterGroups': {},
'version': 'test'
})

Expand Down

0 comments on commit 681d353

Please sign in to comment.