From 0e0db636c7334184a6a48eef229b11c0cf5e2695 Mon Sep 17 00:00:00 2001 From: Patrick Roy Date: Tue, 15 Oct 2024 11:40:41 +0100 Subject: [PATCH] fix: ignore vsock related failure metrics These metrics trigger spuriously, as iperf-vsock does not cleanly shutdown vsock connections at the end of a performance run, resulting in Firecracker occasionally observing incorrectly shut down sockets. Signed-off-by: Patrick Roy --- tests/host_tools/fcmetrics.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/host_tools/fcmetrics.py b/tests/host_tools/fcmetrics.py index 3df7c6166d44..144de0ba2ca8 100644 --- a/tests/host_tools/fcmetrics.py +++ b/tests/host_tools/fcmetrics.py @@ -466,11 +466,19 @@ def flatten_dict(node, prefix: str): metrics.flush() + ignored_failure_metrics = { + # We trigger these spuriously in vsock tests due to iperf-vsock not implementing connection shutdown + # See also https://github.com/stefano-garzarella/iperf-vsock/issues/4 + "fc_metrics.vsock.rx_read_fails", + "fc_metrics.vsock.tx_write_fails", + } + failure_metrics = { key: value for key, value in flattened_metrics.items() if "err" in key or "fail" in key or "panic" in key or "num_faults" in key if value + if key not in ignored_failure_metrics } assert not failure_metrics, json.dumps(failure_metrics, indent=1)