From 0ea83a8ff766f04a073b42f8690d6be164c9104a Mon Sep 17 00:00:00 2001 From: Jack Thomson Date: Tue, 15 Oct 2024 15:33:12 +0000 Subject: [PATCH] Update docs and tests for ARM gdb support Updated docs to now show arm is supported. Updated the build test to run on aarch Signed-off-by: Jack Thomson --- docs/gdb-debugging.md | 6 +++++- tests/integration_tests/build/test_gdb.py | 3 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/gdb-debugging.md b/docs/gdb-debugging.md index 6e96983a3099..80312f443b7d 100644 --- a/docs/gdb-debugging.md +++ b/docs/gdb-debugging.md @@ -2,7 +2,7 @@ Firecracker supports debugging the guest kernel via GDB remote serial protocol. This allows us to connect GDB to the firecracker process and step through debug -the guest kernel. Currently only debugging on x86 is supported. +the guest kernel. The GDB feature requires Firecracker to be booted with a config file. @@ -108,3 +108,7 @@ command in the GDB session which will terminate both. - Currently we support a limited subset of cpu registers for get and set operations, if more are required feel free to contribute. + +- Some assumptions around virtual address configuration on arm have been made. + If the current translation implementation doesn't cover a specific setup, feel + free to contribute. diff --git a/tests/integration_tests/build/test_gdb.py b/tests/integration_tests/build/test_gdb.py index 541807dd5c1b..3c9ebbb6d871 100644 --- a/tests/integration_tests/build/test_gdb.py +++ b/tests/integration_tests/build/test_gdb.py @@ -4,15 +4,12 @@ import platform -import pytest - import host_tools.cargo_build as host MACHINE = platform.machine() TARGET = "{}-unknown-linux-musl".format(MACHINE) -@pytest.mark.skipif(MACHINE != "x86_64", reason="GDB runs only on x86_64.") def test_gdb_compiles(): """Checks that Firecracker compiles with GDB enabled"""