Skip to content

Commit

Permalink
fix: re-add missing parenthesis to A/B script output
Browse files Browse the repository at this point in the history
Fixes: fc6a36e

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
  • Loading branch information
roypat authored and bchalios committed Nov 28, 2023
1 parent 0506126 commit 3ffb276
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/ab_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def ab_performance_test(
msg = (
f"\033[0;32m[Firecracker A/B-Test Runner]\033[0m A/B-testing shows a change of "
f"{format_with_reduced_unit(result.statistic, unit)}, or {result.statistic / old_mean:.2%}, "
f"(from {format_with_reduced_unit(old_mean, unit)} to {format_with_reduced_unit(new_mean, unit)}"
f"(from {format_with_reduced_unit(old_mean, unit)} to {format_with_reduced_unit(new_mean, unit)}) "
f"for metric \033[1m{metric}\033[0m with \033[0;31m\033[1mp={result.pvalue}\033[0m. "
f"This means that observing a change of this magnitude or worse, assuming that performance "
f"characteristics did not change across the tested commits, has a probability of {result.pvalue:.2%}. "
Expand Down

0 comments on commit 3ffb276

Please sign in to comment.