Skip to content

Commit

Permalink
fix: ignore vsock related failure metrics
Browse files Browse the repository at this point in the history
These metrics trigger spuriously, as iperf-vsock does not cleanly
shutdown vsock connections at the end of a performance run, resulting in
Firecracker occasionally observing incorrectly shut down sockets.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
  • Loading branch information
roypat committed Oct 15, 2024
1 parent 82eec3e commit 9364472
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions tests/host_tools/fcmetrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,11 +466,19 @@ def flatten_dict(node, prefix: str):

metrics.flush()

ignored_failure_metrics = [
# We trigger these spuriously in vsock tests due to iperf-vsock not implementing connection shutdown
# See also https://github.com/stefano-garzarella/iperf-vsock/issues/4
"fc_metrics.vsock.rx_read_fails",
"fc_metrics.vsock.tx_write_fails",
]

failure_metrics = {
key: value
for key, value in flattened_metrics.items()
if "err" in key or "fail" in key or "panic" in key or "num_faults" in key
if value
if key not in ignored_failure_metrics
}
assert not failure_metrics, json.dumps(failure_metrics, indent=1)

Expand Down

0 comments on commit 9364472

Please sign in to comment.