Skip to content

Commit

Permalink
doc: add CHANGELOG entry for KVM_KVMCLOCK_CTRL ioctl
Browse files Browse the repository at this point in the history
Mention that we now call KVM_KVMCLOCK_CTRL ioctl on x86_64 after pausing
vCPUs. Clarify that failures to call this ioctl are not fatal and that
we log the failure and increase a metric when these happen.

Signed-off-by: Babis Chalios <bchalios@amazon.es>
  • Loading branch information
bchalios committed Oct 23, 2024
1 parent ce3c8fd commit d0447fb
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ and this project adheres to
`VIRTIO_NET_F_RX_MRGBUF` support to the `virtio-net` device. When this feature
is negotiated, guest `virtio-net` driver can perform more efficient memory
management which in turn improves RX and TX performance.
- [#4460](https://github.com/firecracker-microvm/firecracker/pull/4460): Add a
call to
[`KVM_KVMCLOCK_CTRL`](https://docs.kernel.org/virt/kvm/api.html#kvm-kvmclock-ctrl)
after pausing vCPUs on x86_64 architectures. This ioctl sets a flag in the KVM
state of the vCPU indicating that it has been paused by the host userspace. In
guests that use kvmclock, the soft lockup watchdog checks this flag. If it is
set, it won't trigger the lockup condition. Calling the ioctl for guests that
don't use kvmclock will fail. These failures are not fatal; we log the failure
and increase the `vmm.kvmclock_ctrl_fails` metric.

### Changed

Expand Down

0 comments on commit d0447fb

Please sign in to comment.