fix: ignore vsock related failure metrics #4851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These metrics trigger spuriously, as iperf-vsock does not cleanly shutdown vsock connections at the end of a performance run, resulting in Firecracker occasionally observing incorrectly shut down sockets. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
vsock-metric-ignore
branch
from
0e0db63 to
9364472
Compare
roypat
added
the
Status: Awaiting review
bchalios
reviewed
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
=======================================
Coverage 84.01% 84.01%
=======================================
Files 251 251
Lines 28019 28019
=======================================
Hits 23541 23541
Misses 4478 4478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I kinda just put a |
bchalios
approved these changes
Oct 15, 2024
pb8o
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These metrics trigger spuriously, as iperf-vsock does not cleanly shutdown vsock connections at the end of a performance run, resulting in Firecracker occasionally observing closed sockets. See also stefano-garzarella/iperf-vsock#4
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.