ARM support for GDB #4854
Merged
ARM support for GDB #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4854 +/- ##
==========================================
+ Coverage 84.05% 84.07% +0.01%
==========================================
Files 251 251
Lines 28061 28052 -9
==========================================
- Hits 23588 23586 -2
+ Misses 4473 4466 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
force-pushed
the
feat/gdb_server_arm
branch
5 times, most recently
from
a27a23c to
0ea83a8
Compare
JackThomson2
force-pushed
the
feat/gdb_server_arm
branch
2 times, most recently
from
379c93f to
ed1cfc0
Compare
JackThomson2
added
the
Status: Awaiting review
Manciukic
reviewed
Oct 16, 2024
ShadowCurse
reviewed
Oct 17, 2024
ShadowCurse
reviewed
Oct 17, 2024
JackThomson2
force-pushed
the
feat/gdb_server_arm
branch
from
ed1cfc0 to
40fddf5
Compare
kalyazin
reviewed
Oct 21, 2024
JackThomson2
force-pushed
the
feat/gdb_server_arm
branch
2 times, most recently
from
c3a56b7 to
4112696
Compare
kalyazin
approved these changes
Oct 21, 2024
ShadowCurse
approved these changes
Oct 21, 2024
Add support for debugging aarch64 with gdb Signed-off-by: Jack Thomson <jackabt@amazon.com>
Updated docs to now show arm is supported. Updated the build test to run on aarch Signed-off-by: Jack Thomson <jackabt@amazon.com>
JackThomson2
force-pushed
the
feat/gdb_server_arm
branch
from
4112696 to
e57072f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adding support for GDB debugging on arm machines.
Unfortunately KVM doesn't provide all the same API's we have to use on x86 so some parts have to be manually implemented. Some assumptions around Virtual Address configuration have been made to simplify the implementation.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.