Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't update dependencies when with new vX.Y.0-dev version #4857

Conversation

bchalios
Copy link
Contributor

@bchalios bchalios commented Oct 16, 2024

Reason

We want to do that before creating the release branch so that we can fix issues with new dependencies ahead of the release.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

We want to do that before creating the release branch so that we can fix
issues with new dependencies ahead of the release.

Signed-off-by: Babis Chalios <bchalios@amazon.es>
@bchalios bchalios added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.05%. Comparing base (a4cced0) to head (ecaad70).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4857   +/-   ##
=======================================
  Coverage   84.05%   84.05%           
=======================================
  Files         251      251           
  Lines       28061    28061           
=======================================
  Hits        23588    23588           
  Misses       4473     4473           
Flag Coverage Δ
5.10-c5n.metal 84.68% <ø> (-0.01%) ⬇️
5.10-m5n.metal 84.66% <ø> (ø)
5.10-m6a.metal 83.97% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.67% <ø> (ø)
5.10-m6i.metal 84.66% <ø> (ø)
5.10-m7g.metal 80.67% <ø> (ø)
6.1-c5n.metal 84.68% <ø> (-0.01%) ⬇️
6.1-m5n.metal 84.66% <ø> (ø)
6.1-m6a.metal 83.97% <ø> (ø)
6.1-m6g.metal 80.67% <ø> (ø)
6.1-m6i.metal 84.66% <ø> (-0.01%) ⬇️
6.1-m7g.metal 80.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat merged commit 588e77a into firecracker-microvm:main Oct 16, 2024
7 of 8 checks passed
@bchalios bchalios deleted the dont_bump_dependencies_when_bumping_version branch October 16, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants