Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unpin 5.10/m6i ami #4865

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ShadowCurse
Copy link
Contributor

Changes

Unpin 5.10/m6i ami.

Reason

Performance is stable now on 5.10/m6i instances.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Performance is stable now on 5.10/m6i instances.

Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (c97418a) to head (f809ad3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4865   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         251      251           
  Lines       28052    28052           
=======================================
  Hits        23586    23586           
  Misses       4466     4466           
Flag Coverage Δ
5.10-c5n.metal 84.71% <ø> (ø)
5.10-m5n.metal 84.70% <ø> (+0.01%) ⬆️
5.10-m6a.metal 84.00% <ø> (ø)
5.10-m6g.metal 80.70% <ø> (ø)
5.10-m6i.metal 84.70% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.70% <ø> (ø)
6.1-c5n.metal 84.71% <ø> (ø)
6.1-m5n.metal 84.70% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 84.00% <ø> (-0.01%) ⬇️
6.1-m6g.metal 80.70% <ø> (ø)
6.1-m6i.metal 84.69% <ø> (ø)
6.1-m7g.metal 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShadowCurse ShadowCurse marked this pull request as ready for review October 22, 2024 13:23
@ShadowCurse ShadowCurse self-assigned this Oct 22, 2024
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code labels Oct 22, 2024
@ShadowCurse ShadowCurse merged commit 800ec4c into firecracker-microvm:main Oct 22, 2024
8 of 9 checks passed
@ShadowCurse ShadowCurse deleted the unpin_m6i branch October 22, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants