Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ballet, sbpf: manually register entrypoint to calldests #1868

Merged
merged 1 commit into from
May 16, 2024
Merged

ballet, sbpf: manually register entrypoint to calldests #1868

merged 1 commit into from
May 16, 2024

Conversation

ravyu-jump
Copy link
Contributor

No description provided.

ripatel-fd
ripatel-fd reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic LGTM

@ravyu-jump ravyu-jump marked this pull request as ready for review May 15, 2024 20:28
@ravyu-jump ravyu-jump force-pushed the default-register-entrypoint branch 4 times, most recently from 42c5548 to 72bfe89 Compare May 16, 2024 02:23
@ravyu-jump ravyu-jump changed the title manually register entrypoint to calldests ballet, sbpf: manually register entrypoint to calldests May 16, 2024
@ripatel-fd
Copy link
Contributor

Looks great. Could you fix the indent in the test file? And then squash the commits? (Since our GitHub configuration doesn't allow us to squash). I think we should merge it then.

@ravyu-jump ravyu-jump force-pushed the default-register-entrypoint branch from 72bfe89 to 78c37b6 Compare May 16, 2024 17:37
@ravyu-jump
Copy link
Contributor Author

Could you fix the indent in the test file? And then squash the commits? (Since our GitHub configuration doesn't allow us to squash). I think we should merge it then.

Done, let's have @topointon-jump take a look as well

@ravyu-jump
ballet, sbpf loader: manually register entrypoint to calldests
d728b24 
address PR feedback

add unit test

incorrect makefile params

reformat test file
@ravyu-jump ravyu-jump force-pushed the default-register-entrypoint branch from 78c37b6 to d728b24 Compare May 16, 2024 18:17
@lheeger-jump lheeger-jump added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit dfa4374 May 16, 2024
10 checks passed
@lheeger-jump lheeger-jump deleted the default-register-entrypoint branch May 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheeger-jump lheeger-jump lheeger-jump approved these changes

@topointon-jump topointon-jump Awaiting requested review from topointon-jump

@ripatel-fd ripatel-fd Awaiting requested review from ripatel-fd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravyu-jump @ripatel-fd @lheeger-jump