Remove direct mapping support for ABIv1 #2941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More work is being done on the agave direct mapping on abi v1, not sure if it makes sense to remove any of this just yet... |
@ibhatt-jumptrading Agave just did a testnet restart deactivating ABIv1 direct mapping. So direct mapping is off on all clusters. Anza also promised to not trigger a reactivation. But we should probably coordinate ABIv1 DM removal from Firedancer with removal on the Anza side. |
|
Anza changed their mind recently. They are now planning to activate ABIv1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes parts of the "direct mapping" implementation that are specific to ABIv1.
Leaves intact the CPI and serialization routines because those might be reused for ABIv2 when it is ready.
Not yet ready for merge.
This should be merged only after testnet disables the direct mapping feature.