flamenco: implement verify_ticks #3829
Conversation
src/flamenco/runtime/fd_runtime.c
Outdated
| @@ -827,25 +827,70 @@ fd_runtime_block_prepare( fd_blockstore_t * blockstore, | |||
| return 0; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Maybe it makes sense for this function to be in fd_blockstore... Not sure though
src/flamenco/runtime/fd_runtime.c
Outdated
| return FD_BLOCK_ERR_TRAILING_ENTRY; | ||
| } | ||
|
|
||
| /* Not returning FD_BLOCK_ERR_INVALID_LAST_TICK because we assume the |
There was a problem hiding this comment.
Can you explain why this exists in agave. I am pretty sure that in agave, slot_full is always true
There was a problem hiding this comment.
I don't think we need this complexity. My best guess is that they had/have fantasies about replaying blocks piecemeal and thus verifying ticks before a block is full. We don't have a streaming execution model yet, so all our blocks are either just full, or they are not gonna be replayed at all. When we do eventually move to a streaming execution model, we can always update this function to support streaming tick verification, or just do tick verification at the end of a block.
yufeng-jump
force-pushed
the
yufeng/verify-ticks
branch
16 times, most recently
from
42973b4 to
c01d002
Compare
yufeng-jump
force-pushed
the
yufeng/verify-ticks
branch
from
c01d002 to
e99b145
Compare
yufeng-jump
force-pushed
the
yufeng/verify-ticks
branch
from
e99b145 to
ae2eb86
Compare
No description provided.