flamenco, repair: cache good repair peers to file #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topointon-jump
changed the title
|
This has sandbox issues and seems like a bit of a workaround. Why is it slow to get a fresh list of repair peers on boot? |
topointon-jump
force-pushed
the
topointon/repair-cache-peers
branch
4 times, most recently
from
fac99c2 to
f8191f7
Compare
| @@ -559,17 +568,133 @@ fd_repair_decay_stats( fd_repair_t * glob ) { | |||
| } | |||
There was a problem hiding this comment.
general alignment + spacing nits
topointon-jump
force-pushed
the
topointon/repair-cache-peers
branch
from
ff4620d to
2151c9e
Compare
Corrected the approach to set up the sandbox properly, thanks for the spot 😄
It is slow because we don't have the stake weights until the full snapshot is loaded, and we don't have the IP addresses of the nodes until these are fetched through gossip. We are working on making both of these faster but in the meantime this cache also helps. |
topointon-jump
changed the title
ibhatt-jumptrading
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We periodically cache the known good repair peers to a file, so that we can request from these when we restart. This reduces startup times.