Handholding Extras #3887
Merged
Handholding Extras #3887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
two-heart
previously approved these changes
Jan 8, 2025
ravyu-jump
force-pushed
the
ravyu/handholding-extras
branch
2 times, most recently
from
2daee26 to
c41a059
Compare
ravyu-jump
force-pushed
the
ravyu/handholding-extras
branch
2 times, most recently
from
1d986e2 to
88d0a2a
Compare
ravyu-jump
force-pushed
the
ravyu/handholding-extras
branch
2 times, most recently
from
129bd8b to
936f1cd
Compare
yufeng-jump
reviewed
Jan 9, 2025
There was a problem hiding this comment.
I wonder if we shouldn't just extract the implementation into xxx_impl functions, and then the xxx_debug() variants would call the corresponding impl functions, and the non debug variants would be defined to either impl or debug, depending on whether handholding is on or not. This way we won't have to do the undef hack, and it's abundantly clear that the non debug variants are either just impl or debug.
ravyu-jump
force-pushed
the
ravyu/handholding-extras
branch
from
936f1cd to
ad21efc
Compare
yufeng-jump
previously approved these changes
Jan 10, 2025
ravyu-jump
force-pushed
the
ravyu/handholding-extras
branch
from
ad21efc to
6de0b04
Compare
yufeng-jump
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with-handholding.mkcorrectly activates the handholding macrosUse macros in spad to override default APIs with debug variants