ripatel/v0.3 backports #3897
Merged
ripatel/v0.3 backports #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ripatel-fd
commented
Jan 8, 2025
ripatel-fd
commented
- quic: less aggressive frame errors
- quic: accept streams before handshake confirmed
- quic: fix Identification field being always 0
- quic: fix hs_data_empty cache invalidation bug
- Add missing logging for crypto frame parse failures for CRYPTO, ACK, CONN_CLOSE frames. - Don't drop packets containing RESET_STREAM, NEW_TOKEN, PATH_CHALLENGE, PATH_RESPONSE frames. - Silently ignore HANDSHAKE_DONE frames before the handshake is complete (suppress ACK when still handshaking)
Fixes a bug that causes connections to break if the client eagerly sends stream data.
Fixes a classic C typo with (*ptr++) syntax. The bug resulted in all Firedancer QUIC packets having an IPv4 ID field of 0. Most Internet peers (most notably Linux) are resilient enough to handle this. Should be fixed nonetheless.
Fixes an issue where QUIC handshakes can stall if fd_quic has nothing to send temporarily. This occurs specifically when the client sends an Initial packet that doesn't contain a complete ClientHello. This caused 'hs_data_empty' flag to be set which then suppresses any more TLS handshake progress. There was no logic to reset 'hs_data_empty' when new data arrives. With this fix, we always check for handshake data for as long as a quic_tls_hs object exists. The 'hs_data_empty' bit is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.