Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDS Source: Issue #13673. Remove uninitialized variable #13680

Merged
merged 2 commits into from
Nov 3, 2024
Merged

FDS Source: Issue #13673. Remove uninitialized variable #13680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf3ac52
FDS Source: Issue #13673. Remove uninitialized variable
mcgratta Nov 3, 2024
fe117f0
FDS Source: Remove commented line
mcgratta Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions Source/init.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4795,7 +4795,7 @@ SUBROUTINE REASSIGN_WALL_CELLS(T,NM)
USE COMP_FUNCTIONS, ONLY : CURRENT_TIME
INTEGER, INTENT(IN) :: NM
REAL(EB), INTENT(IN) :: T
INTEGER :: N,I1,I2,J1,J2,K1,K2,I,J,K,IW,ICG,IC,OBST_INDEX,NOM,IIO,JJO,KKO
INTEGER :: I1,I2,J1,J2,K1,K2,I,J,K,IW,ICG,IC,OBST_INDEX,NOM,IIO,JJO,KKO
REAL(EB) :: TNOW
LOGICAL :: CREATE,REMOVE
TYPE (OBSTRUCTION_TYPE), POINTER :: OB
Expand All @@ -4822,17 +4822,18 @@ SUBROUTINE REASSIGN_WALL_CELLS(T,NM)
IC = CELL_INDEX(BC%II ,BC%JJ ,BC%KK )
ICG = CELL_INDEX(BC%IIG,BC%JJG,BC%KKG)
IF (CELL(ICG)%SOLID) CYCLE
OBST_INDEX=0
OBST_INDEX = 0
REMOVE = .FALSE.
CREATE = .FALSE.
CALL GET_BOUNDARY_TYPE
ENDIF
ENDDO

! Loop over all obstructions in the current mesh and initialize newly exposed or covered wall cell faces

OBSTRUCTION_LOOP: DO N=1,N_OBST
OBSTRUCTION_LOOP: DO OBST_INDEX=1,N_OBST

OB => OBSTRUCTION(N)
OBST_INDEX=N
OB => OBSTRUCTION(OBST_INDEX)

IF (.NOT.OB%SCHEDULED_FOR_REMOVAL .AND. .NOT.OB%SCHEDULED_FOR_CREATION) CYCLE OBSTRUCTION_LOOP

Expand Down Expand Up @@ -4964,7 +4965,7 @@ SUBROUTINE GET_BOUNDARY_TYPE
WC => MESHES(NM)%WALL(IW)
BC => MESHES(NM)%BOUNDARY_COORD(WC%BC_INDEX)

IF (IW<=N_EXTERNAL_WALL_CELLS .AND. REMOVE) THEN
IF (IW<=N_EXTERNAL_WALL_CELLS) THEN
EWC => MESHES(NM)%EXTERNAL_WALL(IW)
WC%BOUNDARY_TYPE = SOLID_BOUNDARY
CELL(IC)%SOLID = .TRUE.
Expand Down Expand Up @@ -5023,12 +5024,6 @@ SUBROUTINE GET_BOUNDARY_TYPE
CALL INIT_WALL_CELL(NM,BC%II,BC%JJ,BC%KK,WC%OBST_INDEX,IW,BC%IOR,WC%SURF_INDEX,IERR,T)
WC => MESHES(NM)%WALL(IW)
IF (IW<=N_EXTERNAL_WALL_CELLS) EWC%PRESSURE_BC_TYPE = PRESSURE_BC_TYPE
! This code is under construction
! SF => SURFACE(WC%SURF_INDEX)
! IF (SF%VARIABLE_THICKNESS .OR. SF%HT_DIM>1) THEN
! CALL FIND_WALL_BACK_INDEX(NM,IW)
! CALL REALLOCATE_ONE_D_ARRAYS(NM,WALL_CELL=IW)
! ENDIF
ENDIF

! Special cases 1: BURNed_AWAY obstruction exposes a surface that also burns, in which case the surface is to ignite immediately.
Expand Down