FDS Build: set clean-fds to true for clean-hypre and clean-sundials #13690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
already done. the fds build files are removed/cleaned if either the hypre
or sundials library are built for any reason not just if the --clean-hpre
or --clean-sundials options are specified
…On Mon, Nov 4, 2024 at 2:11 PM Chandan Paul ***@***.***> wrote:
@gforney <https://github.com/gforney>, I wanted to mean that we should
clean fds obj and mod files if --clean-hypre and --clean-sundials are
specified. I did it for the linux part. Could you please do it for the
Windows one.
------------------------------
You can view, comment on, or merge this pull request online at:
#13690
Commit Summary
- b3dd24f
<b3dd24f>
FDS Build: set clean-fds to true if clean-hypre and clean-sundials
specified.
File Changes
(1 file <https://github.com/firemodels/fds/pull/13690/files>)
- *M* Build/Scripts/build_thirdparty_libs.sh
<https://github.com/firemodels/fds/pull/13690/files#diff-5a190f4b263b88a539a3bd0afaf685ad737019f2c77f67d5ad72a88a4130e9a9>
(2)
Patch Links:
- https://github.com/firemodels/fds/pull/13690.patch
- https://github.com/firemodels/fds/pull/13690.diff
—
Reply to this email directly, view it on GitHub
<#13690>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC6UCRTE72ZNCR5YCQT3M4TZ662ERAVCNFSM6AAAAABRE5SPS6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZTGNRSGQ4TCMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Glenn Forney
|
|
let me know if you see something different |
|
@gforney Great, I just tested the Windows version, and it's working as you described. I see that you're removing FDS files within both build_hypre.bat and build_sundials.bat, so the Windows version looks good. Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gforney, I wanted to mean that we should clean fds obj and mod files if --clean-hypre and --clean-sundials are specified. I did it for the linux part. Could you please do it for the Windows one.