Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README API docs sections #198

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Update README API docs sections #198

merged 1 commit into from
Oct 6, 2023

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Oct 6, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation

What is the current behavior?

Issue Number: N/A

Placing the API documentation in the README is inefficient and creates double work to manage it since the Swagger documentation already exists.

What is the new behavior?

Replace the "API Endpoint" and "Query Parameters" sections with a "Documentation" section that directs the reader to the generated Swagger documentation.

Other information

None

Replace "API Endpoint" and "Query Parameters" section with "Documentation" section
@fityannugroho fityannugroho added the documentation Improvements or additions to documentation label Oct 6, 2023
@fityannugroho fityannugroho added this to the v4.0.0 milestone Oct 6, 2023
@fityannugroho fityannugroho merged commit 5f68a51 into main Oct 6, 2023
4 checks passed
@fityannugroho fityannugroho deleted the api-docs branch October 6, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant