Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code style configuration #467

Merged
merged 10 commits into from
Nov 23, 2024
Merged

Update code style configuration #467

merged 10 commits into from
Nov 23, 2024

Conversation

fityannugroho
Copy link
Owner

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • The commit message follows our Contributing Guidelines
  • Tests for the changes have been added (optional, for bug fixes or features)
  • Docs have been added / updated (optional, for bug fixes or features)

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

What is the new behavior?

This pull request involves several updates to code style management, dependency imports, and code refactoring. The changes primarily focus on updating the code style tool, refactoring import statements, and improving code readability and consistency.

Code Style Management:

  • Enabled linter recommended rules
  • Disabled useImportType rule
  • Remove redundant rules settings
  • Enabled import organization
  • Updated the schema version in biome.json

[1] [2]

Dependency Imports:

  • Refactored import statements to follow a consistent order and grouping. (prisma/seed.ts, src/common/decorator/EqualsAny.ts, src/common/decorator/IsNotSymbol.ts, src/common/interceptor/transform.interceptor.ts, src/common/utils/__tests__/package.spec.ts, src/common/utils/runner.ts, src/district/district.controller.ts, src/district/district.dto.ts, src/district/district.module.ts, src/district/district.service.spec.ts, src/island/island.controller.ts, src/island/island.dto.ts)[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

Code Refactoring:

  • Replaced parseInt with Number.parseInt and parseFloat with Number.parseFloat for better readability and consistency. (src/common/config/app.ts, src/common/utils/coordinate.ts, src/common/utils/data.ts) [1] [2] [3]
  • Simplified the validateDBConfig function by renaming variables for clarity. (src/common/utils/db/index.ts)

These changes improve the overall code quality, maintainability, and consistency across the codebase.

Other information

None

@fityannugroho fityannugroho added the refactor Change code without add, update, or delete any features label Nov 23, 2024
@fityannugroho fityannugroho merged commit d31093e into main Nov 23, 2024
11 checks passed
@fityannugroho fityannugroho deleted the style-biome branch November 23, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Change code without add, update, or delete any features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant