[Feature] Update collect_freshness config in src_apple_store.yml to account for dbt macro logic #12
Closed
2 of 4 tasks
Labels
priority:p4
Affects few users; pick up when available
type:enhancement
New functionality or enhancement
update_type:testing
Primary focus requires testing updates
Is there an existing feature request for this?
Describe the Feature
Our fivetran_utils
collect_freshness
macro was designed to override dbt's equivalent macro to allow for the enabling/disabling of variables when runningdbt source snapshot-freshness
. Thus if a source table does not exist, dbt will not run (and error on) a freshness test on the table.dbt has since updated its macro in recent versions to basically provide the same functionality. So warnings are being thrown to upgrade the package logic.
We will want to modify all versions of the
meta: is_enabled
config in oursrc_apple_store.yml
package ([example here])(https://github.com/fivetran/dbt_apple_store_source/blob/main/models/src_apple_store.yml#L188-L189) to match theconfig: enabled
dbt logic. Once those dependencies are either updated or removed, we can further explore updates to our own internalcollect_freshness
macro.Describe alternatives you've considered
At the moment, we will be proceeding forward with updating
dbt_fivetran_utils
to match the logic of dbt'scollect_freshness
macro. That way customers will no longer experience that warning.More details can be found in this ticket.
Are you interested in contributing this feature?
Anything else?
Customers raising this issue can be found in this dbt slack thread https://getdbt.slack.com/archives/C03SAHKKG2Z/p1683127164993329
The text was updated successfully, but these errors were encountered: