Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Union schema compatibility #14

Merged
merged 21 commits into from
Jul 23, 2024

Conversation

fivetran-catfritz
Copy link
Contributor

@fivetran-catfritz fivetran-catfritz commented Jul 15, 2024

Issue:

Confirm/fix the following files were correctly updated automatically:

  • CHANGELOG
  • README
  • stg_apple_store.yml, src_apple_store.yml
  • docs.md
  • joins
  • window functions (partition by)
  • 'source_relation' column added in staging models
  • tests
  • version bumps

Manual updates:

  • Add source_relation if necessary
  • Finish any incomplete/incorrect joins/partitions
  • Update tests to include source_relation in unique-combination-of-cols if necessary
    • May need to remove some uniqueness tests in favor of the combo test

Validation:

  • Spot check with seed data, unioning is functioning as expected.

    • Screenshot 2024-07-18 at 11 30 59 AM
  • Also:

    • see internal ticket

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-catfritz great work on this PR! I just have a few small requests before approving this PR. Let me know if you have any questions. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@fivetran-joemarkiewicz
Copy link
Collaborator

Also before merging we should add the auto releaser to this package.

Copy link
Contributor Author

@fivetran-catfritz fivetran-catfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-joemarkiewicz Thank you. I have updated, and this is ready for re-review!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making the changes!

@fivetran-reneeli fivetran-reneeli self-requested a review July 23, 2024 19:04
@fivetran-reneeli fivetran-reneeli removed their request for review July 23, 2024 19:15
@fivetran-catfritz fivetran-catfritz merged commit fce24ad into main Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Update collect_freshness config in src_apple_store.yml to account for dbt macro logic
2 participants