-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Union schema compatibility #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-catfritz great work on this PR! I just have a few small requests before approving this PR. Let me know if you have any questions. Thanks!
Also before merging we should add the auto releaser to this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-joemarkiewicz Thank you. I have updated, and this is ready for re-review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for making the changes!
Issue:
Confirm/fix the following files were correctly updated automatically:
window functions (partition by)Manual updates:
source_relation
if necessarysource_relation
in unique-combination-of-cols if necessaryValidation:
Spot check with seed data, unioning is functioning as expected.
Also: