feat: added rest delete FW endpoint

src/test/integration/web_interface/rest/test_rest_firmware.py

@@ -144,3 +144,11 @@ def test_rest_download_with_summary(self, backend_db):
             f'/rest/firmware/{test_firmware.uid}?summary=true', follow_redirects=True
         )
         assert test_firmware.processed_analysis['dummy']['summary'][0].encode() in request_with_summary.data
+
+    def test_rest_delete(self, backend_db):
+        test_firmware = create_test_firmware(device_class='test class', device_name='test device', vendor='test vendor')
+        backend_db.add_object(test_firmware)
+        assert backend_db.is_firmware(test_firmware.uid)
+
+        self.test_client.delete(f'/rest/firmware/{test_firmware.uid}')
+        assert backend_db.is_firmware(test_firmware.uid) is False

src/test/unit/web_interface/rest/test_rest_firmware.py

@@ -20,6 +20,7 @@
     'tags': 'tag1,tag2',
     'requested_analysis_systems': ['file_type'],
 }
+DELETED_FILES = 1337
 
 
 class DbMock(CommonDatabaseMock):
@@ -39,6 +40,12 @@ def get_complete_object_including_all_summaries(uid):
         fw.processed_analysis['dummy']['summary'] = {'included_files': 'summary'}
         return fw if uid == fw.uid else None
 
+    def is_firmware(self, uid):
+        return uid == TEST_FW.uid
+
+    def delete_firmware(self, uid):
+        return DELETED_FILES, DELETED_FILES
+
 
 @pytest.mark.WebInterfaceUnitTestConfig(database_mock_class=DbMock)
 class TestRestFirmware:
@@ -171,3 +178,14 @@ def test_request_with_summary(self, test_client):
         result = test_client.get(f'/rest/firmware/{TEST_FW.uid}?summary=true').json
         assert 'firmware' in result
         assert 'summary' in result['firmware']['analysis']['dummy'], 'included file summaries should be included'
+
+    def test_delete_success(self, test_client):
+        result = test_client.delete(f'/rest/firmware/{TEST_FW.uid}').json
+        assert 'error_message' not in result
+        assert 'deleted_files' in result
+        assert result['deleted_files'] == DELETED_FILES
+
+    def test_delete_unknown_uid(self, test_client):
+        result = test_client.delete('/rest/firmware/foobar').json
+        assert 'error_message' in result
+        assert result['error_message'] == 'No firmware with UID foobar found'

src/web_interface/rest/rest_firmware.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 import binascii
 import logging
 from base64 import standard_b64decode
@@ -214,3 +216,14 @@ def _update_analysis(self, uid, update):
         if unpack:
             update.append('unpacker')
         return success_message({}, self.URL, {'uid': uid, 'update': update})
+
+    @roles_accepted(*PRIVILEGES['delete'])
+    def delete(self, uid: str) -> tuple[dict, int]:
+        """
+        Delete existing firmware including all unique unpacked files (i.e. all files not occurring in other firmware)
+        and all analyses.
+        """
+        if not self.db.frontend.is_firmware(uid):
+            return error_message(f'No firmware with UID {uid} found', self.URL, {'uid': uid})
+        _, deleted_files = self.db.admin.delete_firmware(uid)
+        return success_message({'deleted_files': deleted_files}, self.URL, {'uid': uid})