converted elf_analysis plugin to new base class #1266
Conversation
jstucke
force-pushed
the
elf-analysis-plugin-v1
branch
from
c14b112 to
b307c7e
Compare
jstucke
force-pushed
the
elf-analysis-plugin-v1
branch
from
b307c7e to
afec839
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
- Coverage 92.21% 91.93% -0.29%
==========================================
Files 377 378 +1
Lines 23068 21104 -1964
==========================================
- Hits 21273 19402 -1871
+ Misses 1795 1702 -93 ☔ View full report in Codecov by Sentry. |
| for section in elf.sections: | ||
| if section.name == '.modinfo': | ||
| modinfo = section.content.tobytes() | ||
| modinfo = [entry.decode() for entry in modinfo.split(b'\x00') if entry] |
There was a problem hiding this comment.
Should we handle decoding errors here?
There was a problem hiding this comment.
We will probably encounter only ascii but it won't hurt either
src/helperFunctions/hash.py
Outdated
| def normalize_lief_items(functions): | ||
| def normalize_lief_items(functions) -> list[str]: |
There was a problem hiding this comment.
Couldn't we remove this function completely?
Why is this in helperFunctions.hash anyways?
There was a problem hiding this comment.
removed (or rather inlined)
| header: ElfHeader | ||
| sections: List[ElfSection] | ||
| segments: List[ElfSegment] | ||
| dynamic_entries: List[DynamicEntry] | ||
| exported_functions: List[ElfSymbol] | ||
| imported_functions: List[str] | ||
| mod_info: Optional[List[str]] | ||
| note_sections: List[InfoSectionData] | ||
| behavior_classes: List[str] |
There was a problem hiding this comment.
Shouldn't we document these?
Imo, we should at least document the non-standart ones like mod_info and behavior_classes.
There was a problem hiding this comment.
documented both fields
| sections=[ElfSection.model_validate(s) for s in json_dict['sections']], | ||
| segments=[ElfSegment.model_validate(s) for s in json_dict['segments']], | ||
| dynamic_entries=[DynamicEntry.model_validate(e) for e in json_dict['dynamic_entries']], |
There was a problem hiding this comment.
Imo the code gets more readable if we do not serialize the lief elf representation to json.
E.g. like the exported_functions above.
and also removed the redundant normalize_lief_items method
jstucke
force-pushed
the
elf-analysis-plugin-v1
branch
from
700a7d4 to
64db148
Compare
No description provided.