New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect agent_id and deleted_at for topologies #1167

Merged

moshloop merged 1 commit into master from respect-deleted-agent-id

Jul 20, 2023

Member

yashmehrotra commented Jul 20, 2023

No description provided.


          fix: respect agent_id and deleted_at for topologies

cfe6edc

yashmehrotra requested a review from moshloop

July 20, 2023 04:20

yashmehrotra commented

View reviewed changes

pkg/db/topology.go

               func GetAllTopologiesForSync() ([]v1.Topology, error) {
               	var v1topologies []v1.Topology
               	var topologies []pkg.Topology
-              	if err := Gorm.Table("topologies").Find(&topologies).Where("deleted_at is NULL AND namespace != 'push'").Error; err != nil {

Member Author

yashmehrotra Jul 20, 2023

Since .Find was being called first and is a finisher method, we were never respecting deleted at

moshloop merged commit dddab13 into master

11 checks passed

yashmehrotra deleted the respect-deleted-agent-id branch

August 2, 2023 07:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet