chore: remove wrong error log #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Jan 3, 2024
pkg/controllers/canary_controller.go
Outdated
| @@ -229,7 +230,7 @@ func (r *CanaryReconciler) Report() { | |||
| var canary v1.Canary | |||
| err := r.Get(gocontext.Background(), payload.NamespacedName, &canary) | |||
| if err != nil { | |||
| r.Log.Error(err, "failed to get canary", "canary", payload.NamespacedName) | |||
| logger.Debugf("failed to fetch canary while reporting (possibly not a CRD): %v", err) | |||
There was a problem hiding this comment.
Can we not check the source and not even attempt it ifs not a crd ?
yashmehrotra
force-pushed
the
remove-wrong-error-log
branch
2 times, most recently
from
a865450
to
16a3867
Compare
yashmehrotra
force-pushed
the
remove-wrong-error-log
branch
from
16a3867
to
7672e19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.