Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transformed checks returning correct id #1556

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

yashmehrotra
Copy link
Member

No description provided.

@@ -58,7 +58,7 @@ func (c *postgresCache) AddCheckFromStatus(check pkg.Check, status pkg.CheckStat
}

if check.ID != uuid.Nil {
return uuid.Nil, nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop Not sure why this was set to nil uuid

Due to this being nil id, existing checks were marked deleted instead of being updated

@moshloop moshloop merged commit 1531c0e into master Jan 3, 2024
14 checks passed
@yashmehrotra yashmehrotra deleted the transformed-fix branch January 4, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants