Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transformed checks returning correct id #1556

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: transformed checks returning correct id #1556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cache/postgres.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (c *postgresCache) AddCheckFromStatus(check pkg.Check, status pkg.CheckStat
}

if check.ID != uuid.Nil {
return uuid.Nil, nil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moshloop Not sure why this was set to nil uuid

Due to this being nil id, existing checks were marked deleted instead of being updated

return check.ID, nil
}

return db.PersistCheck(c.DB(), check, check.CanaryID)
Expand Down
1 change: 1 addition & 0 deletions pkg/jobs/canary/canary_jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ func (j CanaryJob) Run(ctx dutyjob.JobRuntime) error {

// Update last runtime map
canaryLastRuntimes.Store(canaryID, time.Now())
ctx.History.SuccessCount = len(results)
return nil
}

Expand Down
Loading