fix: add unique event validation

flanksource · Jul 28, 2023 · 8492c66 · 8492c66
1 parent 16ba49e
commit 8492c66
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/events/events.go b/events/events.go
@@ -3,6 +3,8 @@ package events
 import (
 	"time"
 
+	"github.com/flanksource/commons/collections/set"
+	"github.com/flanksource/commons/logger"
 	"github.com/flanksource/incident-commander/api"
 	"gorm.io/gorm"
 )
@@ -59,7 +61,14 @@ func StartConsumers(gormDB *gorm.DB, config Config) {
 		allConsumers = append(allConsumers, NewUpstreamPushConsumer(gormDB, config))
 	}
 
+	uniqWatchEvents := set.New[string]()
 	for _, c := range allConsumers {
+		for _, we := range c.WatchEvents {
+			if uniqWatchEvents.Contains(we) {
+				logger.Fatalf("Error starting consumers: event[%s] has multiple consumers", we)
+			}
+		}
+		uniqWatchEvents.Add(c.WatchEvents...)
 		go c.Listen()
 	}
 }
diff --git a/events/notifications.go b/events/notifications.go
@@ -19,7 +19,7 @@ import (
 func NewNotificationConsumer(db *gorm.DB) EventConsumer {
 	return EventConsumer{
 		WatchEvents: []string{
-			EventNotificationSend, EventNotificationUpdate, EventNotificationDelete,
+			EventNotificationUpdate, EventNotificationDelete,
 			EventIncidentCreated,
 			EventIncidentResponderRemoved,
 			EventIncidentDODAdded, EventIncidentDODPassed, EventIncidentDODRegressed,