Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications #428

Closed
moshloop opened this issue Jul 4, 2023 · 2 comments · Fixed by #436
Closed

Notifications #428

moshloop opened this issue Jul 4, 2023 · 2 comments · Fixed by #436
Assignees

Comments

@moshloop
Copy link
Member

moshloop commented Jul 4, 2023

Ability to add custom notifications for:

  • canary_pass, canary_fail, canary_transition

  • incident.assign, create, resolve, close, comment

  • definition_of_done.pass|fail|transition

  • Can specify either an inline notification, or a team

  • Label filtering

  • Cel/Exprv based filtering of events.

@moshloop moshloop changed the title Notifications Team Notifications Jul 4, 2023
@moshloop moshloop changed the title Team Notifications Notifications Jul 5, 2023
@moshloop
Copy link
Member Author

moshloop commented Jul 6, 2023

Destination can be a notification handler or a team or person

@adityathebe
Copy link
Member

adityathebe commented Jul 6, 2023

List of Events (draft)

1. check

event description
check.passed when a previously failing check passes
check.failed when a previously passing check fails

Env vars

  • check
  • canary

2. incident

event description
incident.created when an incident is created

Env vars

  • incident

2.1 responder

event description
incident.responder.added when a responder is added to the incident
incident.responder.removed when a responder is removed from the incident

Env vars

  • responder

2.2 comment

event description
incident.comment.added when there's a new comment

Env vars

  • comment
  • comment.mentions <SetOf(mentioned users' emails)>

2.3. definition of done

event description
incident.dod.added when a dod is added
incident.dod.removed when an existing dod is removed
incident.dod.passed when a previously failing dod passes
incident.dod.regressed when a previously passing dod fails

Env vars

  • evidence

2.4. Status update

event description
incident.status.resolved when an incident is resolved
incident.status.mitigated when an incident is mititgated
incident.status.investigating when an incident is marked as investigating
incident.status.closed when an incident is closed

@adityathebe adityathebe linked a pull request Jul 12, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants