Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: notification wait for #1407

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat: notification wait for #1407

merged 3 commits into from
Sep 18, 2024

Conversation

adityathebe
Copy link
Member

resolves: #1406

@adityathebe adityathebe force-pushed the feat/notification-delay branch 2 times, most recently from a142e47 to a453bab Compare September 17, 2024 06:17
moshloop
moshloop reviewed Sep 17, 2024
View reviewed changes
notification/events.go Outdated Show resolved Hide resolved
moshloop
moshloop reviewed Sep 17, 2024
View reviewed changes
notification/events.go
Name: api.EventNotificationSend,
Properties: payload.AsMap(),
Delay: n.WaitFor,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to insert a pending notification into notification send.history and then update it on final send

@moshloop moshloop merged commit 3f02fd2 into main Sep 18, 2024
7 checks passed
@moshloop moshloop deleted the feat/notification-delay branch September 18, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notification - wait delay
2 participants
@adityathebe @moshloop