Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more details to postgrest spans #1417

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Conversation

adityathebe
Copy link
Member

@adityathebe adityathebe commented Sep 18, 2024

resolves: #829

The otel echo middleware doesn't offer the flexibility to customize the span name.

image

@moshloop
Copy link
Member

@adityathebe can we make the span name /db/table_name ?

@adityathebe
Copy link
Member Author

adityathebe commented Sep 18, 2024

@adityathebe can we make the span name /db/table_name ?

@moshloop I don't think the echo otel middleware allows it

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/a6c39275e680e3316303c2f6210d1cc5fb1752cf/instrumentation/github.com/labstack/echo/otelecho/echo.go#L70-L76

Should we fork it?

echo/serve.go Outdated Show resolved Hide resolved
echo/serve.go Outdated Show resolved Hide resolved
@moshloop moshloop enabled auto-merge (squash) September 18, 2024 20:26
@moshloop
Copy link
Member

@adityathebe it is not that important for now

@moshloop moshloop merged commit fcc115d into main Sep 18, 2024
7 checks passed
@moshloop moshloop deleted the feat/postgrest-calls-trace branch September 18, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve tracing of forwarded postgrest calls
2 participants