Staking clients #22
Merged
Staking clients #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanc-flare
approved these changes
Sep 25, 2023
| func (c *indexerContext) Flags() *IndexerFlags { return c.flags } | ||
|
|
||
| func parseIndexerFlags() *IndexerFlags { | ||
| cfgFlag := flag.String("config", globalConfig.CONFIG_FILE, "Configuration file (toml format)") |
There was a problem hiding this comment.
Just a general comment, personally I like using the argparse library for parsing command-line args, I prefer it to the builtin flag package. Not expecting you to change it here but just in case you want to check it out.
|
Oh I see there is just one failing linter check: If that can be fixed then I am happy to merge 🙂 |
Remove Epoch config and use on-chain values
mboben
pushed a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.