Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja2 version mismatch with flask2.0 #398

Open
kvalv opened this issue Jul 21, 2021 · 10 comments
Open

Jinja2 version mismatch with flask2.0 #398

kvalv opened this issue Jul 21, 2021 · 10 comments

Comments

@kvalv
Copy link

kvalv commented Jul 21, 2021

Hi,

So for flask2.0 requirements, the minimum required version for Jinja is 3.0, whereas the flask monitoring dashboard requirements are pinned to 2.11.1. This is unfortunate as it means it's not possible to create a consistent set of requirements for flask 2.0 with flask monitoring dashboard.

Is it possible to remove this pinned requirement?

As a sidenote, I can see that it has already been removed on the development branch, and I ideally want a new release that I can use instead of having to specify a commit / branch that works with flask 2.0. 🛩️

To reproduce:

cd /tmp
mkdir foo && cd foo
python3.7 -m venv myvenv
. ./.myvenv/bin/activate
pip install pip-tools
echo "flask>=2.0\nflask_monitoringcashboard" > requirements.in
pip-compile  # this fails
@Gresliebear
Copy link

I am gettting tthe same issue

flask-monitoringdashboard 3.1.0 has requirement jinja2==2.11.1, but you'll have jinja2 3.0.1 which is incompatible.

@mircealungu
Copy link
Member

If you look in the requirements.txt you'll see that the jinja2 is pinned to 2.11.1 in order to prevent breaking python 3.6... Does any one of you use 3.6 to confirm that the problem does not exist with Jinja 3.0.1? Thanks!

@kvalv
Copy link
Author

kvalv commented Jul 29, 2021

Hey, unfortunately I do not use 3.6 so I am not able to confirm it. I could try take a look in python3.6 to see whether that's the case, but I don't really know what I'm looking for

@mircealungu
Copy link
Member

mircealungu commented Jul 29, 2021

Hi @kvalv !

Don't worry, the bug is fixed in the upcoming release: #399

There is only one issue that I'd still like to fix before that release: Issue #400. I just don't have the time to work on it yet. Do you know Angular? :)

@kvalv
Copy link
Author

kvalv commented Aug 3, 2021

Oh, that is nice to hear!

Unfortunately, I have very little knowledge of angular 😛

@tddough98
Copy link

Any update on the 3.1.1 release in #399? I'm finding myself needing to use Flask 2 and FMD is the only dependency blocking me

@mircealungu
Copy link
Member

Hi @tddough98 - thanks for the reminder! we'll try to release asap!

@tddough98
Copy link

Is there anything blocking the 3.1.1 release? I see that there is one issue #400 mentioned above but it looks like the bug is present in 3.1.0 too. Can the fix for #400 be pushed to 3.1.2 so that improvements from 3.1.1 can make it out?

@mircealungu
Copy link
Member

thanks @tddough98 for the reminder.
I'll try to create the release in this weekend!

@HrisyToteva
Copy link

Hi @kvalv thank you for bringing up this issue and taking the time to contribute to the Flask-MonitoringDashboard project.

As part of my school project, my team is conducting a usability research study to improve the dashboard. I noticed your experience with the app and thought it would be valuable to gather more insights from you.

Would you be open to receiving a few questions about your experience with Flask-MonitoringDashboard? It won't take more than 20 minutes to answer them. Your feedback will play a vital role in enhancing the app's functionality and addressing any existing limitations.

If you're interested, please let me know, and I will send you the questions. Your involvement would be highly valuable and greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants