Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omaha: Write only SHA256 hash for extra files #629

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Commits on Dec 2, 2022

  1. frontend: Move pipe out of literal text

    The hash tip was rendered as
    "Tip: cat update.gz false openssl dgst -sha1 -binary false base64"
    where "false" should be "|".
    Using "|" does not work in the literal text but it works through
    templating (which is also nicer for translation).
    pothos committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    ed0ef7f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. omaha: Use both SHA1 and SHA256 hashes for extra files

    For extra files there is only one hash attribute but it was used for
    both a SHA1 and SHA256 entry in the Omaha response. On the wire and in
    the UI it's unclear which of the formats it should be.
    Use two entries in the database for each hash format and make clear what
    the format looks like, i.e., base64 or hex. With a change in go-omaha
    we can also omit the empty regular SHA1 hash entry but in any case the
    client would be expected to know about the SHA256 attribute and use this
    instead. This would match what's done in
    https://chromium.googlesource.com/chromium/src.git/+/master/docs/updater/protocol_3_1.md
    pothos committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    243cc32 View commit details
    Browse the repository at this point in the history
  2. syncer: Use stored file name when self-hosting

    The syncer in self-hosting mode will download the files and store them
    with new names. The new name wasn't used for the extra file entries.
    Update the extra file entries to use the new name.
    pothos committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    3367ec2 View commit details
    Browse the repository at this point in the history
  3. Dockerfile: For now disable the Go Module Proxy

    The download for go-bindata failed for no reason, it seems there is a
    problem with the proxy server.
    Disable the proxy server for now.
    pothos committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    bedc58c View commit details
    Browse the repository at this point in the history
  4. Use latest go-omaha version

    There are changes in the go-omaha version that haven't been used yet by
    Nebraska. One of them is to omit empty hash attributes.
    Use the latest commit ID in both the backend and the client library.
    pothos committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    f9eddf3 View commit details
    Browse the repository at this point in the history