Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-kernel/coreos-modules: Enable dm-verity signature support #1115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jepio
Copy link
Member

@jepio jepio commented Sep 6, 2023

Enable dm-verity signature support

This allows checking against the primary kernel keyring, but not the secondary. It is a prerequisite for the ioctl to inject the signature to be supported in the first place.

How to use

Test with sysext with signature: flatcar/sysext-bakery#24.

Testing done

Not yet. Will see if ioctl still reports error after an image for this PR is built.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

This allows checking against the primary kernel keyring, but not the secondary.
It is a prerequisite for the ioctl to inject the signature to be supported in
the first place.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio temporarily deployed to development September 6, 2023 16:01 — with GitHub Actions Inactive
@pothos
Copy link
Member

pothos commented Sep 6, 2023

I think we can also enable the secondary keyring with CONFIG_DM_VERITY_VERIFY_ROOTHASH_SIG_SECONDARY_KEYRING

The other options mentioned in flatcar/Flatcar#855 require a newer kernel
Edit: Forgot we are on 6.1, so CONFIG_INTEGRITY_MACHINE_KEYRING should work, too

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/6310953367

@dongsupark
Copy link
Member

Moved to backlog. Feel free to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants