-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OEM systemd-sysext images and Flatcar extensions #1016
Conversation
2f80c38
to
76f88cc
Compare
76f88cc
to
04d742c
Compare
04d742c
to
3228c2a
Compare
3228c2a
to
b041d6b
Compare
b041d6b
to
22cb99d
Compare
22cb99d
to
fe03ba3
Compare
fe03ba3
to
6a94a91
Compare
6a94a91
to
82bf3ad
Compare
82bf3ad
to
50905a0
Compare
50905a0
to
d5daa5a
Compare
d5daa5a
to
c40f3c9
Compare
c40f3c9
to
46441af
Compare
46441af
to
fd62ad5
Compare
fd62ad5
to
ce198bf
Compare
ce198bf
to
67e5023
Compare
c7bc20a
to
aec5322
Compare
50781e7
to
7d66a67
Compare
sdk_container/src/third_party/coreos-overlay/coreos-base/misc-files/misc-files-0.ebuild
Outdated
Show resolved
Hide resolved
718bf7f
to
d72d746
Compare
22e1ee8
to
7b25b11
Compare
7b25b11
to
1370eb2
Compare
1370eb2
to
e3aa677
Compare
@@ -0,0 +1,13 @@ | |||
/etc/systemd/system/nvidia.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that the deletion happens after /etc is already overlaid? Also hopefully this won't delete third party files that accidentally had the same name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, after the overlay. For user files with the same service name that we bring in I think the most practical solution is to document this because the same service name used will have other issues, too, I will add it to the changelog.
The vendor tools on the OEM partition weren't updated. We now want to ship them as systemd-sysext images which we can easily update. This change extends the Flatcar A/B update mechanism to cover the OEM systemd-sysext images. The same mechanism is also able to support "official" Flatcar extensions, e.g., a ZFS extension.
The kola run didn't pick up the version that was set up in the build because the git changes from that step are lost. Redo the version setup in the kola run to use the same version, and skip the kola update test if no update payload can be found. In the future we should copy it over from the GitHub Action artifact.
e3aa677
to
ddb808f
Compare
The vendor tools on the OEM partition weren't updated. We now want to
ship them as systemd-sysext images which we can easily update. This
change extends the Flatcar A/B update mechanism to cover the OEM
systemd-sysext images. The same mechanism is also able to support
"official" Flatcar extensions, e.g., a ZFS extension.
Additional change:
The kola run didn't pick up the version that was set up in the build
because the git changes from that step are lost.
Redo the version setup in the kola run to use the same version, and
skip the kola update test if no update payload can be found. In the
future we should copy it over from the GitHub Action artifact.
How to use
After merging we always need to publish signed OEM payloads during release.
Used PRs:
flatcar/update_engine#24
flatcar/mantle#448
flatcar/bootengine#68
flatcar/init#101
When merging, create a follow-up GitHub issue for proper update tests on GitHub Actions PR builds (only for the regular update test, that should be easily doable). Done: flatcar/Flatcar#1172
Testing done
See update-engine PR, Jenkins run is here
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.