Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation for Secure boot support #1589

Merged
merged 25 commits into from
Feb 26, 2024
Merged

Initial implementation for Secure boot support #1589

merged 25 commits into from
Feb 26, 2024

Conversation

sayanchowdhury
Copy link
Member

@sayanchowdhury sayanchowdhury commented Jan 18, 2024 •
edited
Loading

Initial implementation for Secure boot support

This PR updates shim to use upstream, adds test secure boot keys, and a new qemu_uefi_secure format which produces a Secure Boot.

To be merged with https://github.com/flatcar/jenkins-os/pull/325

How to use

for i in flatcar_production_qemu_uefi_secure_efi_code.fd flatcar_production_qemu_uefi_secure_efi_vars.fd flatcar_production_qemu_uefi_secure_image.img.bz2 flatcar_production_qemu_uefi_secure.sh
do
axel -n 40 https://bincache.flatcar-linux.net/images/amd64/9999.9.9+sayan-secureboot-changes/$i
done
chmod +x flatcar_production_qemu_uefi_secure.sh
bzip2 -d flatcar_production_qemu_uefi_secure_image.img.bz2
./flatcar_production_qemu_uefi_secure.sh -a ~/.ssh/id_rsa.pub -p 2222 --nographic
ssh core@localhost -p 2222

core@localhost ~ $ mokutil --sb-state
SecureBoot enabled

Testing done

CI Running http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1276/cldsv/

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@sayanchowdhury sayanchowdhury requested a review from a team January 18, 2024 19:02
@pothos
Copy link
Member

pothos commented Jan 18, 2024

Could we have a single image type or does presence of a signature disrupt the booting when secure boot is disabled?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 18, 2024 •
edited
Loading

Test report for 3888.0.0+nightly-20240222-2100 / amd64 arm64

Platforms tested : qemu_uefi-amd64 qemu_update-amd64 qemu_uefi-arm64 qemu_update-arm64

ok bpf.execsnoop 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok bpf.local-gadget 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.basic 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.cgroupv1 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.cloudinit.basic 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.cloudinit.multipart-mime 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.cloudinit.script 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.disk.raid0.data 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.disk.raid0.root 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.disk.raid1.data 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.disk.raid1.root 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.etcd-member.discovery 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.etcd-member.etcdctlv3 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.etcd-member.v2-backup-restore 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.filesystem 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.flannel.udp 🟢 Succeeded: qemu_uefi-amd64 (1)

ok cl.flannel.vxlan 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.instantiated.enable-unit 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.kargs 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.luks 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.indirect 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.indirect.new 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.regular 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.regular.new 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.reuse 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.oem.wipe 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.partition_on_boot_disk 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.symlink 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.translation 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.btrfsroot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.ext4root 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.groups 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.once 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.sethostname 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.users 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v1.xfsroot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2.btrfsroot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2.ext4root 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2.users 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2.xfsroot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2_1.ext4checkexisting 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2_1.swap 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.ignition.v2_1.vfat 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.install.cloudinit 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.internet 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.locksmith.cluster 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.misc.falco 🟢 Succeeded: qemu_uefi-amd64 (1)

ok cl.network.initramfs.second-boot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.network.listeners 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.network.wireguard 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.omaha.ping 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.osreset.ignition-rerun 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.overlay.cleanup 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.swap_activation 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.sysext.boot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.sysext.fallbackdownload # SKIP 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.toolbox.dnf-install 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.update.badverity 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.update.grubnop 🟢 Succeeded: qemu_uefi-amd64 (1)

ok cl.update.payload 🟢 Succeeded: qemu_update-amd64 (1); qemu_update-arm64 (1)

ok cl.update.reboot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.users.shells 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok cl.verity 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.auth.verify 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.groups 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.once 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.resource.local 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.resource.remote 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.resource.s3.versioned 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.security.tls 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.sethostname 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.ignition.systemd.enable-service 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.locksmith.reboot 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.locksmith.tls 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.selinux.boolean 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.selinux.enforce 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.tls.fetch-urls 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok coreos.update.badusr 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok devcontainer.docker 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok devcontainer.systemd-nspawn 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.btrfs-storage 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.containerd-restart 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.devicemapper-storage 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.enable-service.sysext 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.lib-coreos-dockerd-compat 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.network 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.selinux 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok docker.userns 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok extra-test.[first_dual].cl.update.docker-btrfs-compat 🟢 Succeeded: qemu_update-amd64 (1); qemu_update-arm64 (1)

ok extra-test.[first_dual].cl.update.payload 🟢 Succeeded: qemu_update-amd64 (1); qemu_update-arm64 (1)

ok kubeadm.v1.26.5.calico.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.26.5.calico.cgroupv1.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.26.5.cilium.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.26.5.cilium.cgroupv1.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.26.5.flannel.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.26.5.flannel.cgroupv1.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.27.2.calico.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.27.2.cilium.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.27.2.flannel.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.28.1.calico.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.28.1.cilium.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok kubeadm.v1.28.1.flannel.base 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (2) ❌ Failed: qemu_uefi-arm64 (1)

                Diagnostic output for qemu_uefi-arm64, run 1 
    L1: "  "
    L2: " Error: _kubeadm.go:264: unable to setup cluster: unable to create etcd node: machine __19965a2c-01fc-4efa-a56d-3ef89161039b__ failed basic checks: some systemd units failed:"
    L3: "??? iscsiuio.service loaded failed failed iSCSI UserSpace I/O driver"
    L4: "status: "
    L5: "journal:-- No entries --_"
    L6: " "

ok linux.nfs.v3 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok linux.nfs.v4 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok linux.ntp 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok misc.fips 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok packages 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok sysext.custom-docker.sysext 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok sysext.custom-oem 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok sysext.disable-containerd 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok sysext.disable-docker 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok sysext.simple 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok systemd.journal.remote 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok systemd.journal.user 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

ok systemd.sysusers.gshadow 🟢 Succeeded: qemu_uefi-amd64 (1); qemu_uefi-arm64 (1)

@pothos
Copy link
Member

pothos commented Jan 18, 2024

Could we have a single image type or does presence of a signature disrupt the booting when secure boot is disabled?

I don't see a new image type added in the commits, so is this already present? I would like to understand whether this means to have additional images for every cloud or if we have the same number of images as before but only an additional qemu script.

@sayanchowdhury
Copy link
Member Author

CI Running (dropped shim cros_workon) http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1278/cldsv/

@sayanchowdhury
Copy link
Member Author

sayanchowdhury commented Jan 19, 2024 •
edited
Loading

Could we have a single image type or does presence of a signature disrupt the booting when secure boot is disabled?

I don't see a new image type added in the commits, so is this already present? I would like to understand whether this means to have additional images for every cloud or if we have the same number of images as before but only an additional qemu script.

No, we can merge the same into the qemu_uefi, and one can toggle from BIOS to disable Secureboot, and Flatcar would boot just fine. I created a new variant as I'm still working for the implementation on the other cloud providers and tests.

The reason for creating the PR is so that after merge we can deprecate the shim repo.

@sayanchowdhury
Copy link
Member Author

CI Running (dropped shim cros_workon) http://jenkins.infra.kinvolk.io:8080/job/container/job/sdk/1278/cldsv

CI Passed.

@miao0miao miao0miao mentioned this pull request Jan 19, 2024
Closed
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Closed
sayanchowdhury and others added 13 commits February 26, 2024 12:01
@sayanchowdhury @pothos
sys-boot/shim: updates to 15.7
fc4acb6 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
sys-boot/shim: make the shim buildable
65fe1f4 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
coreos-sb-keys: Add the shim keys
348a262 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
sys-boot/shim: Update shim to include signing keys, and build mm.efi
b42e3ad 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
grub_install.sh: Sign the GRUB/MM with the proper keys
0479480 
Add the linux.mod file back

Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@jepio @pothos
grub_install: switch to BOARD_GRUB by default
6455625 
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@sayanchowdhury @pothos
sys-boot/grub: install file with sbat contents, add --sbat to script
fc28e72 
This is just the contents of the section, but the section
itself is written by grub-mkimage. sbat.csv needs to be passed
with --sbat.

Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@jepio @pothos
Add support for secure boot in qemu_template.sh
6ff9f8b 
We have an existing qemu_uefi_secure format definition, but it is
necessary to update it so that it actually works. Qemu needs to be
passed the correct flags to enable SMM, we need to switch to the Q35
machine, and we need to copy over the secboot variant of the OVMF
firmware.
@sayanchowdhury @pothos
build_image_util: Sign the vmlinuz with the shim key
c1bdbd9 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
build_library: Drop redundant config from grub.cfg
0400565 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
sys-boot/shim: Move from cros_workon to upstream
97ebc77 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @tormath1 @pothos
sys-boot/grub: Make sed silently fail when updating sbat
4648be9 
Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
@sayanchowdhury @pothos
shim, coreos-sb-keys, grub_install.sh: retab to spaces
99bfcf5 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@pothos pothos requested a review from krnowak February 26, 2024 14:13
krnowak
krnowak approved these changes Feb 26, 2024
View reviewed changes
changelog/changes/2024-01-25-shim-secureboot-update.md Outdated Show resolved Hide resolved
...tainer/src/third_party/coreos-overlay/sys-firmware/edk2-aarch64/edk2-aarch64-20220221.ebuild
@@ -0,0 +1,23 @@
# Copyright (c) 2024 The Flatcar Maintainers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if this question was answered. Does it block the PR?

sayanchowdhury and others added 6 commits February 26, 2024 15:46
@sayanchowdhury @pothos
sys-boot/shim: Add the changelog for shim upgrade, and secureboot
0fc380c 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
vendor-testing: Add qemu_uefi_secure, symlinked to qemu.sh
16b3a2a 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
.github/workflow: Add the packages to automation list
3bc6944 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
grub_install.sh: ship mokmanager, and rename to grubx64
52ce21a 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@sayanchowdhury @pothos
ci-automation: Update to include the qemu_uefi_secure test
3627046 
Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
@pothos
sys-boot/shim: Update to 15.8
7db81c2
@pothos pothos merged commit d35414a into main Feb 26, 2024
1 check failed
@pothos pothos deleted the sayan/secureboot-changes branch February 26, 2024 14:46
@sayanchowdhury sayanchowdhury mentioned this pull request Feb 26, 2024
Closed
@github-actions github-actions bot mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pothos pothos pothos approved these changes

@ader1990 ader1990 ader1990 left review comments

@jepio jepio jepio left review comments

@tormath1 tormath1 tormath1 left review comments

@krnowak krnowak krnowak approved these changes

@dongsupark dongsupark dongsupark approved these changes

Assignees
No one assigned
Labels
main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sayanchowdhury @pothos @ader1990 @krnowak @jepio @dongsupark @tormath1