Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys-boot/grub: Adjust version string to include flatcar1 suffix #2333

Merged
merged 1 commit into from
Sep 26, 2024

Commits on Sep 17, 2024

  1. sys-boot/grub: Adjust version string to include flatcar1 suffix

    We will bump this every time we or Gentoo change patches that modify
    parts of GRUB that are installed to the boot partition. We will reset
    the version back to 1 when the upstream GRUB version changes.
    
    Without this, we are bound by Gentoo's PVR string, which we cannot
    change when we need to make changes to our own patches. The shim review
    wants to know the full version number of our GRUB build, and it would
    look bad to make such changes without changing the version.
    
    This suffix is also applied to the Flatcar entry in the SBAT, which is
    especially important for the shim review.
    
    The published binary package will still be labelled with the Gentoo PVR,
    but that seems less important given that end users cannot update
    individual packages on Flatcar installations.
    
    Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
    chewi committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    59953b7 View commit details
    Browse the repository at this point in the history