SDK container: include circular dependency breaking packages in SDK container #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change builds all packages required to break circular dependencies
and includes these in the SDK image. This way, emerge-<arch> can be used
right away and build_packages only builds packages with production USE
flags.
The change significantly reduces the build time at the cost of a larger
SDK image and longer SDK container build time. Uncompressed:
Size before Size after
all arches 7.75GB 9.29GB
arm64 5.7GB 6.58GB
amd64 5.64GB 6.45GB
Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/10992298154 |
chewi
approved these changes
Sep 23, 2024
❤️ I don't like the ~2GB increase in SDK image size either 😞 Hopefully we can do away with this as a stop-gap solution in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds all packages required to break circular dependencies in the "build SDK container" stage and includes these in the SDK image. This way, emerge- can be used right away and build_packages only builds packages with production USE flags.
The change significantly reduces the build time at the cost of a larger SDK image and longer SDK container build time. Uncompressed:
How to use
./build_sdk_container_image -k flatcar-sdk-amd64-4098.0.0+nightly-20240919-2100.tar.bz2(NOTE: this must run outside the SDK container, on your host)./run_sdk_container -t -C ghcr.io/flatcar/flatcar-sdk-amd64:4098.0.0-nightly-20240919-2100 emerge-amd64-usr systemdTesting done
Ran the above, successfully emerged systemd for both amd64 and arm64.
Github actions
/update-sdk