Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-admin/locksmith: Stop using deprecated resource control options #859

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

krnowak
Copy link
Member

@krnowak krnowak commented May 31, 2023

@krnowak krnowak added the main label May 31, 2023
@krnowak krnowak requested a review from a team May 31, 2023 11:48
@krnowak
Copy link
Member Author

krnowak commented May 31, 2023

/build-image

@github-actions
Copy link

github-actions bot commented May 31, 2023

Build action triggered: https://github.com/flatcar/scripts/actions/runs/5414170236

@t-lo
Copy link
Member

t-lo commented May 31, 2023

For some reason the build workflow now thinks that no command was issued 😞
Let's try once more:

/build-image

@krnowak
Copy link
Member Author

krnowak commented Jun 6, 2023

/build-image

@krnowak krnowak force-pushed the krnowak/locksmith-resource-control branch from e68b607 to 411514c Compare June 6, 2023 13:31
@krnowak krnowak changed the title app-admin/locksmith: Stop using deprecates resource control options app-admin/locksmith: Stop using deprecated resource control options Jun 6, 2023
@krnowak krnowak force-pushed the krnowak/locksmith-resource-control branch from 411514c to 5b42997 Compare June 27, 2023 15:18
@krnowak krnowak temporarily deployed to development June 27, 2023 15:18 — with GitHub Actions Inactive
@krnowak
Copy link
Member Author

krnowak commented Jun 28, 2023

/build_image

@krnowak
Copy link
Member Author

krnowak commented Jun 29, 2023

Tests passed, ready for review.

Copy link
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Adding changelog would be great as well.

@krnowak
Copy link
Member Author

krnowak commented Jun 29, 2023

Added the changelog, merging.

@krnowak krnowak merged commit 398ee10 into main Jun 29, 2023
1 check failed
@krnowak krnowak deleted the krnowak/locksmith-resource-control branch June 29, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants