Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require SageMath to be installed #34

Merged
merged 11 commits into from
Nov 25, 2023
Merged

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Nov 9, 2023

No description provided.

@saraedum saraedum changed the title Run doctests without SageMath installed Also run doctests without SageMath installed Nov 9, 2023
@saraedum
Copy link
Member Author

saraedum commented Nov 9, 2023

@videlec should veerer still support to run without SageMath?

@videlec
Copy link
Contributor

videlec commented Nov 9, 2023

Good question. It is doable to have veerer in pure python but also extra work to maintain.

@saraedum
Copy link
Member Author

saraedum commented Nov 9, 2023

Good question. It is doable to have veerer in pure python but also extra work to maintain.

I don't think it's worth it. Who would want to use veerer in a context where SageMath is not viable? I mean, it doesn't solve a non-mathematical problem (like cysignals say) and if somebody for some reason wanted to use it from Mathematica or something like that, I guess they could be bothered to also install SageMath somehow. It's a substantial hurdle for sure but unless I am mistaken the possible user community is very small for veerer in the first place.

we concluded that it's unrealistic that somebody needs this package
without being able to install SageMath. The effort to maintain such a
package is too high for such an unlikely use case (it's essentially
Windows users…)
@saraedum saraedum changed the title Also run doctests without SageMath installed Require SageMath to be installed Nov 13, 2023
Copy link
Contributor

@videlec videlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@videlec videlec merged commit 894f8a5 into flatsurf:master Nov 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants