-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common tsdocs #68
Common tsdocs #68
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 98 98
Lines 14386 14720 +334
Branches 1316 1316
==========================================
+ Hits 14386 14720 +334
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
- Left some comments in the code
- Please use @throw tag when applicable
* const array = [1, 2, 3, 4, 5]; | ||
* const chunks = chunk(array, 2); | ||
* console.log(chunks); | ||
* // [[1, 2], [3, 4], [5]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
packages/common/src/utils/array.ts
Outdated
@@ -81,6 +121,22 @@ export function orderBy<T>( | |||
}); | |||
} | |||
|
|||
/** | |||
* Returns true if arrays are equal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using "Checks" instead of "Returns true" for this and other cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a good idea,
Refactored!
No description provided.