Clarify test names, exercise matching code slightly more

fleetdm · Sep 26, 2024 · c1e8eed · c1e8eed
1 parent a512821
commit c1e8eed
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/server/datastore/mysql/software_installers_test.go b/server/datastore/mysql/software_installers_test.go
@@ -1135,7 +1135,7 @@ func testGetOrGenerateSoftwareInstallerTitleID(t *testing.T, ds *Datastore) {
 			},
 		},
 		{
-			name: "title that already exists, bundle identifier in payload",
+			name: "title that already exists, mismatched bundle identifier in payload",
 			payload: &fleet.UploadSoftwareInstallerPayload{
 				Title:            "Existing Title",
 				Source:           "apps",
@@ -1149,6 +1149,14 @@ func testGetOrGenerateSoftwareInstallerTitleID(t *testing.T, ds *Datastore) {
 				Source: "apps",
 			},
 		},
+		{
+			name: "title that already exists, no bundle identifier in DB, bundle identifier in payload",
+			payload: &fleet.UploadSoftwareInstallerPayload{
+				Title:            "Existing Title Without Bundle",
+				Source:           "apps",
+				BundleIdentifier: "com.new.bundleid",
+			},
+		},
 		{
 			name: "title that doesn't exist, no bundle identifier in payload",
 			payload: &fleet.UploadSoftwareInstallerPayload{

diff --git a/server/datastore/mysql/vpp_test.go b/server/datastore/mysql/vpp_test.go
@@ -1255,6 +1255,14 @@ func testGetOrInsertSoftwareTitleForVPPApp(t *testing.T, ds *Datastore) {
 				BundleIdentifier: "",
 			},
 		},
+		{
+			name: "title that already exists, no bundle identifier in DB, bundle identifier in payload",
+			app: &fleet.VPPApp{
+				Name:             "Existing Title Without Bundle",
+				LatestVersion:    "0.0.3",
+				BundleIdentifier: "new.bundle.id",
+			},
+		},
 		{
 			name: "title that doesn't exist, no bundle identifier in payload",
 			app: &fleet.VPPApp{