Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miss makezero in slice init #19290

Closed
alingse opened this issue May 27, 2024 · 2 comments
Closed

miss makezero in slice init #19290

alingse opened this issue May 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working as documented #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Milestone

Comments

@alingse
Copy link

alingse commented May 27, 2024

Fleet version:

Web browser and operating system:


💥  Actual behavior

TODO

🧑‍💻  Steps to reproduce

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242994149/job/25426541553

====================================================================================================
append to slice `commandUUIDs` with non-zero initialized length at https://github.com/fleetdm/fleet/blob/main/server/datastore/mysql/microsoft_mdm.go#L42[9](https://github.com/alingse/go-linter-runner/actions/runs/9242994149/job/25426541553#step:4:10):18
====================================================================================================

the commandUUIDs := make([]string, len(payloads)) should be commandUUIDs := make([]string, 0, len(payloads))

🕯️ More info (optional)

N/A

@alingse alingse added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented labels May 27, 2024
@georgekarrv georgekarrv added #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release. and removed :reproduce Involves documenting reproduction steps in the issue :incoming New issue in triage process. labels May 28, 2024
@mna mna self-assigned this Jun 4, 2024
@PezHub
Copy link
Contributor

PezHub commented Jun 12, 2024

spoke with Martin and agreed this will be covered as part of Windows MDM smoke tests, no need for a ticket-specific QA pass for this.

@georgekarrv georgekarrv added this to the 4.52.0 milestone Jun 18, 2024
@fleet-release
Copy link
Contributor

Slice init made right,
Fleet's code flows like a stream,
Clear, under moonlight.

@georgekarrv georgekarrv added :demo and removed :demo labels Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as documented #g-mdm MDM product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~released bug This bug was found in a stable release.
Development

No branches or pull requests

5 participants